Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing action clients in robot_navigator(BasicNavigator) to destroy_node #4698

Conversation

tiwaojo
Copy link
Contributor

@tiwaojo tiwaojo commented Oct 1, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #4696 )
Primary OS tested on Ubuntu-24.04 (via Devcontainer Docker)
Robotic platform tested on
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Added action clients to the destroy_node function that were preventing the BasicNavigator node from completely releasing its resources

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@SteveMacenski SteveMacenski merged commit 3233c84 into ros-navigation:main Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants