Skip to content

Commit

Permalink
fix(dependency_walker): don't get dependencies of non ROS packages
Browse files Browse the repository at this point in the history
In case we consider non-ROS dep, we don't want to look for
the ROS dependencies of non ROS packages (ie: cmake)
  • Loading branch information
Guillaumebeuzeboc committed Apr 6, 2023
1 parent aab3bf5 commit c742995
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/rosdistro/dependency_walker.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ def _get_package_names(self):

def get_depends(self, pkg_name, depend_type, ros_packages_only=False):
'''Return a set of package names which the package depends on.'''
deps = self._get_dependencies(pkg_name, depend_type)
deps = set()
# We can only get the dependencies of ROS packages
if pkg_name in self._get_package_names():
deps = self._get_dependencies(pkg_name, depend_type)
if ros_packages_only:
deps &= set(self._get_package_names())
return deps
Expand Down

0 comments on commit c742995

Please sign in to comment.