Do not register extension points with colcon #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an independent tool built on colcon's framework, this tool should not register its extension points as colcon extension points. This should prevent it from appearing in colcon-devtools output, namely version-check. This isn't to say that extension point registration and presence in colcon-devtools wouldn't provide any benefit, this is an effort to avoid "kitchen sinking" colcon as a command line tool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 13 13
Lines 674 674
Branches 176 176
=======================================
Hits 529 529
Misses 128 128
Partials 17 17 ☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an independent tool built on colcon's framework, this tool should not register its extension points as colcon extension points. This should prevent it from appearing in colcon-devtools output, namely version-check.
This isn't to say that extension point registration and presence in colcon-devtools wouldn't provide any benefit, this is an effort to avoid "kitchen sinking" colcon as a command line tool.