Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for pip configuration when an externally managed environment is detected. #979

Merged
merged 24 commits into from
Aug 15, 2024

Commits on Aug 8, 2024

  1. Raise an error when an externally managed environment is detected.

    rosdep is designed to treat pip like an alternative system-level package
    manager. Deviating from this approach is not easily achievable without a
    significant rethinking of how pip packages are managed. In the meantime,
    we can at least instruct users how to restore the prior functionality.
    
    Rather than inject the environment variable / config on behalf of the
    user, this change instructs them to make the necessary config changes
    themself, keeping them informed of the change their making to the
    system's new default.
    nuclearsandwich committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    696be7b View commit details
    Browse the repository at this point in the history
  2. Fix typos and punctuation.

    Co-authored-by: Christophe Bedard <[email protected]>
    nuclearsandwich and christophebedard authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c121579 View commit details
    Browse the repository at this point in the history
  3. Use tuple rather than list literal.

    Co-authored-by: Christophe Bedard <[email protected]>
    nuclearsandwich and christophebedard authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e9ad440 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    8ce4a75 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c76686 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    29ec176 View commit details
    Browse the repository at this point in the history
  4. flake8 cleanup

    nuclearsandwich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    48b9da2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a5e10e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f042758 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a2adfe8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5b2cc64 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    73ed28a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f1dffc6 View commit details
    Browse the repository at this point in the history
  11. Fix errors in config checker.

    The fallback configuration was over-indented and would never be
    checked.
    nuclearsandwich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f685769 View commit details
    Browse the repository at this point in the history
  12. Change formatting of rosdep.

    Use monospace formatting when referring to the `rosdep` command /
    executable name and simply 'rosdep' when referring to the project.
    
    The preferred capitalization of rosdep is rosdep not Rosdep or ROSdep
    (and certainly not ROSDep).
    nuclearsandwich committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    65c7152 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f8472d2 View commit details
    Browse the repository at this point in the history
  14. Add period to end of sentence.

    Co-authored-by: Christophe Bedard <[email protected]>
    nuclearsandwich and christophebedard authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    70775f4 View commit details
    Browse the repository at this point in the history
  15. Add period to end of sentence.

    Co-authored-by: Christophe Bedard <[email protected]>
    nuclearsandwich and christophebedard authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    25ac0e0 View commit details
    Browse the repository at this point in the history
  16. Invert conditional for an earlier return.

    Co-authored-by: Christophe Bedard <[email protected]>
    nuclearsandwich and christophebedard authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8c57dba View commit details
    Browse the repository at this point in the history
  17. Edit text for clarity and typos.

    Co-authored-by: Christophe Bedard <[email protected]>
    nuclearsandwich and christophebedard authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    56a745a View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    a2e9a1e View commit details
    Browse the repository at this point in the history
  2. Fix control flow after inverting the conditional.

    This is a fixup after two earlier changes inverted the conditional and
    reformatted an internal check.
    nuclearsandwich committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    f14c6de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b48f13 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Use ConfigParser.getboolean to check config value.

    Using the dict access method will raise a KeyError when the config file
    is present but this section or value is missing.
    nuclearsandwich committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8e94ef1 View commit details
    Browse the repository at this point in the history