Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more than one release of Visual Studio #74

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

claraberendsen
Copy link
Contributor

@claraberendsen claraberendsen commented Jun 18, 2024

Description

Borrowing from the work done on #72, this PR adds the flexibility to specify VS release version on the solo file.
Paired with:

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that a couple more formatting style changes are needed but otherwise this looks ready to go.

cookbooks/ros2_windows/recipes/visual_studio.rb Outdated Show resolved Hide resolved
cookbooks/ros2_windows/recipes/visual_studio.rb Outdated Show resolved Hide resolved
Co-authored-by: Steven! Ragnarök <[email protected]>
"source": {
"ros2.repos": "rolling"
},
"ros2_ws": "C:/dev/ros2_ws",
"install_connext": "false",
"install_connext": "false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. JSON

@clalancette
Copy link
Contributor

Going ahead and merging this one in.

@clalancette clalancette merged commit c04bd87 into latest Oct 1, 2024
@clalancette clalancette deleted the claraberendsen/multiple-vs-support branch October 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants