Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing solo.rb file #70

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

Add missing solo.rb file #70

wants to merge 2 commits into from

Conversation

j-rivero
Copy link

Closses: #12 . Mostly importing #12 (comment) with linter proposed changes.

Signed-off-by: Jose Luis Rivero <[email protected]>
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should modify the path of this command

> c:\cinc-project\cinc\bin\cinc-solo -c ros2-cookbooks\.chef\solo.rb -j ros2_windows.json

in this readme https://github.com/ros-infrastructure/ros2-cookbooks/blob/latest/cookbooks/ros2_windows/README.md

solo.rb Outdated Show resolved Hide resolved
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@j-rivero j-rivero requested a review from ahcorde June 18, 2024 17:49
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should modify the path of this command

> c:\cinc-project\cinc\bin\cinc-solo -c ros2-cookbooks\.chef\solo.rb -j ros2_windows.json

in this readme https://github.com/ros-infrastructure/ros2-cookbooks/blob/latest/cookbooks/ros2_windows/README.md

this comment is still pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants