Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xmllint download url. #37

Open
wants to merge 4 commits into
base: latest
Choose a base branch
from
Open

Update xmllint download url. #37

wants to merge 4 commits into from

Commits on Oct 1, 2021

  1. Make xmllint download url an attribute. 

    This makes it easier to change the xmllint download url in configuration
rather than via code changes.
    @nuclearsandwich
    nuclearsandwich committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    9739471 View commit details
    Browse the repository at this point in the history

  2. Use ROS download server for xmllint downloads. 

    As a workaround for some host SSL issues we have rehosted these binaries
on a host which does not use Let's Encrypt for HTTPS certificates.
    @nuclearsandwich
    nuclearsandwich committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    a5f9583 View commit details
    Browse the repository at this point in the history

  3. Guard against a url parameter with no trailing slash. 

    This will result in a doubled slash in the url in some cases but that
should be benign to most web servers.
    @nuclearsandwich
    nuclearsandwich committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    18b4eb1 View commit details
    Browse the repository at this point in the history

  4. Revert "Use ROS download server for xmllint downloads." 

    This reverts commit a5f9583.

This was not a sufficient temporary workaround.
    @nuclearsandwich
    nuclearsandwich committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    0e35a49 View commit details
    Browse the repository at this point in the history