[REP-156] Define coordinate frame conventions for marine robots #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/new-ros-enhancement-proposal-for-marine-robotics/36218/27 |
|
Looks good to me! |
JayHerpin
approved these changes
Apr 16, 2024
arjo129
approved these changes
Apr 16, 2024
|
Looks good to me! I agree with the proposal. |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This REP proposes coordinate frame conventions for marine robots that use ROS. This has been proposed with the goal of encouraging interoperability across marine robotics projects where it is common to see SNAME notation 1 used. Discussion leading up to this proposal has taken place in a ROS Discourse thread 2.
Status
Ready to review after getting feedback from the maritime community!
Footnotes
https://www.sname.org/node/2005 ↩
https://discourse.ros.org/t/new-ros-enhancement-proposal-for-marine-robotics/36218 ↩