Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dh_shlibdeps entry for libraries installed by ament_vendor #732

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 29, 2024

It seems that dh_shlibdeps needs to know about each location where shared object libraries are installed so that it knows which libraries are provided by a package. This is particularly important information in the context of multiple inter-linked libraries within a single package.

The ament_vendor macro provided by ament_cmake_vendor_package installs to the opt/{package_name} sub-tree, so we should search for dynamic libraries there as well.

https://man7.org/linux/man-pages/man1/dh_shlibdeps.1.html

@cottsay cottsay self-assigned this Mar 29, 2024
@cottsay
Copy link
Member Author

cottsay commented Mar 29, 2024

This should unblock the gazebo vendoring and eliminate the rviz_ogre_vendor patches we apply today.

@cottsay
Copy link
Member Author

cottsay commented Mar 29, 2024

(maybe not the entire rviz_ogre_vendor patch, but I'm skeptical that the plugins in the OGRE subdirectory need to be part of this).

@cottsay cottsay mentioned this pull request Mar 29, 2024
Copy link

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally with gz_dartsim_vendor and it worked great! Thanks @cottsay

@cottsay cottsay merged commit 4f05240 into master Mar 29, 2024
15 checks passed
@cottsay cottsay deleted the cottsay/ament_vendor-shlibdeps branch March 29, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants