Readd mode arguments to openni2.launch #102
Conversation
update package.xml for noetic support
|
I think it is good to restore this. I suggest keep the documentation line as well as described in 576b616#diff-f75072e949914a0b3f6d5ac4c7307380d93396eadd46d0ddf4c9a98fae6f3e83L21-L24 I suggest to update the Might be best to rebase and merge into |
|
Thank you for the contribution. I won't have a room to take a closer look nor test myself. Nor have I time to address the suggestion #102 (comment). That said, with @MatthijsBurgh comment, I'm inclined to merging (and depend on the OSS community to test). In a few days I might merge unless we'll receive objections. |
| <?xml version="1.0"?> | ||
| <package format="3"> |
There was a problem hiding this comment.
| <?xml version="1.0"?> | |
| <package format="3"> | |
| <?xml version="1.0"?> | |
| <?xml-model | |
| href="http://download.ros.org/schema/package_format3.xsd" | |
| schematypens="http://www.w3.org/2001/XMLSchema"?> | |
| <package format="3"> |
| @@ -32,6 +32,9 @@ | |||
| doc="This arg is not used. Preserved only for backward compatibility." /> | |||
| <arg name="auto_white_balance" default="true" | |||
| doc="This arg is not used. Preserved only for backward compatibility." /> | |||
| <arg name="color_mode" default="5" /> | |||
There was a problem hiding this comment.
| <arg name="color_mode" default="5" /> | |
| <!-- Resolution and FPS setting for each channel --> | |
| <arg name="color_mode" default="5" /> |
There was a problem hiding this comment.
@130s As mentioned in my previous comment. We should also update openni2_tf_prefix.launch before merging this one.
When we have updated that file too. I will approve.
(I don't have write access in this organization, so I can't edit this PR.)
These args were lost on 576b616
Afaik there's no other way to specify at startup the mode, and changing the mode after the node is running via dynamic reconfigure is something that we'd like to avoid.