Functions with return type not returning anything

[jlack1987]

Working on the current release of kinetic-devel it looks like there are some compiler warnings generated for a few methods in InterfaceManager that have a return type but don't have a return statement. The offenders are here, here, and here.

Haven't looked into what these methods actually do, so it might technically not be a problem, but since my group develops with -Werror on by default it's a pain to have to now go manually ignore it with -Wno-return-type. Also seems like kinda bad c++ foo. Thanks!

[bmagyar]

Hi Jordan,
Long time, no see ;)

That bit of metaprogramming arrived with combined_robot_hw and I am not fully familiar with it.
Maybe @toliver could help us out on this one?

[davetcoleman]

+1 to fixing these warnings, i am experiencing them too on Lunar

[mathias-luedtke]

should be fixed in #285 ;)