Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Cleanup includes (backport #943) #959

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 2, 2024

This is an automatic backport of pull request #943 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb10e3e) 45.40% compared to head (8adc3f6) 45.40%.
Report is 1 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble     #959   +/-   ##
=======================================
  Coverage   45.40%   45.40%           
=======================================
  Files          40       40           
  Lines        3713     3713           
  Branches     1769     1769           
=======================================
  Hits         1686     1686           
  Misses        812      812           
  Partials     1215     1215           
Flag Coverage Δ
unittests 45.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...jectory_controller/joint_trajectory_controller.hpp 0.00% <ø> (ø)
...include/joint_trajectory_controller/tolerances.hpp 45.00% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 47.87% <ø> (ø)

(cherry picked from commit f14396c)
@bmagyar bmagyar merged commit 73961f2 into humble Jan 4, 2024
12 of 14 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-943 branch January 4, 2024 09:14
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants