Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for using new get_node_options API #840

Merged

Conversation

saikishor
Copy link
Member

Needs: ros-controls/ros2_control#1169

This PR adds fixes to the tests to support using the new get_node_options API that is present inside the controller interface

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please extend also the tutorial on writing new controllers to announce the new possibility.

@saikishor saikishor force-pushed the controller_node_options_method branch from ac58998 to 8e4c33a Compare November 20, 2023 19:37
@saikishor
Copy link
Member Author

LGTM, but please extend also the tutorial on writing new controllers to announce the new possibility.

@christophfroehlich Done

Copy link
Contributor

mergify bot commented Nov 20, 2023

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the controller_node_options_method branch from 8e4c33a to 27640eb Compare November 20, 2023 21:43
Copy link
Contributor

mergify bot commented Dec 21, 2023

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor force-pushed the controller_node_options_method branch from 27640eb to e72ba34 Compare January 14, 2024 21:19
Copy link
Contributor

mergify bot commented Jan 22, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor
Copy link
Member Author

@bmagyar I'm fixing it now. I will push them in few min

@saikishor
Copy link
Member Author

@bmagyar the semi-binary builds are passing now!

@bmagyar bmagyar merged commit 2817f27 into ros-controls:master Feb 1, 2024
9 of 15 checks passed
pac48 pushed a commit to pac48/ros2_controllers that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants