-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gpio command controller #1251
base: master
Are you sure you want to change the base?
Gpio command controller #1251
Conversation
… params and align UTs
…rams struct instead. Use default member initializer.
…nitialize_gpio_state_msg methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. The unit tests looks pretty extensive.
It would be nice if a maintainer could allow the CI to run on your PR.
There was some issue with includes I've fixed it so jobs can be run more time. |
I've fixed docks and pre-commit jobs other two jobs failed due to pid controller and ackermann steering controller. |
@christophfroehlich could you rerun the CI? |
It appears that the CI is unstable and is failing on the diff drive and pid controller. |
Binary builds due to a recent API breaking change. Semi-binary seems to be happy. |
Okay, so what steps should be taken to merge the pr? |
Someone has to find time to test and review it.. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
+ Coverage 80.36% 80.81% +0.45%
==========================================
Files 105 108 +3
Lines 9390 9723 +333
Branches 828 843 +15
==========================================
+ Hits 7546 7858 +312
- Misses 1570 1586 +16
- Partials 274 279 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As I discussed with @christophfroehlich I've opened new pr with gpio controller.
This PR is a follow-up to the thread and implements a controller to send commands to GPIO interfaces, allowing specific command interfaces for each GPIO.
I have made the following changes compared to the original PR: