Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use reviewer lottery from ros2_control_ci #1049

Merged

Conversation

christophfroehlich
Copy link
Contributor

Fixes reviewer lottery from #1047, see ros-controls/ros2_control#1402 for more details.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f7e9e9) 47.71% compared to head (e8a7bed) 71.72%.
Report is 26 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1049       +/-   ##
===========================================
+ Coverage   47.71%   71.72%   +24.00%     
===========================================
  Files          41       41               
  Lines        3871     3639      -232     
  Branches     1833     1780       -53     
===========================================
+ Hits         1847     2610      +763     
+ Misses        751      715       -36     
+ Partials     1273      314      -959     
Flag Coverage Δ
unittests 71.72% <ø> (+24.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes

@bmagyar
Copy link
Member

bmagyar commented Feb 17, 2024

No access to the lottery strangely...

@christophfroehlich
Copy link
Contributor Author

as I described already, pull_request_target event uses the workflow from the target branch. This means, it does not use the file from this PR but the broken one from master branch

@bmagyar bmagyar merged commit 219a121 into ros-controls:master Feb 19, 2024
15 of 17 checks passed
@christophfroehlich christophfroehlich deleted the fix_reviewer_lottery branch February 19, 2024 18:55
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants