Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Use correct ref for scheduled workflows #1013

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[CI] Use correct ref for scheduled workflows #1013

merged 1 commit into from
Feb 5, 2024

Conversation

christophfroehlich
Copy link
Contributor

  • workflow schedules are (only) run from master branch
  • without giving an explicit ref argument the humble+iron workflows have checked out the master branch, which obviously fails
  • fixed now with this if-clause in the ref field

See also ros-controls/ros2_control#1361

bmagyar
bmagyar approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bmagyar bmagyar merged commit 737a45b into ros-controls:master Feb 5, 2024
10 of 16 checks passed
@christophfroehlich christophfroehlich deleted the ci_scheduled_wfs branch February 5, 2024 07:31
pac48 pushed a commit to pac48/ros2_controllers that referenced this pull request Feb 6, 2024
@christophfroehlich @pac48
Use correct ref for scheduled workflows (ros-controls#1013)
9cb63e8
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 7, 2024
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
@christophfroehlich @mergify
Use correct ref for scheduled workflows (#1013)
3eaf158 
(cherry picked from commit 737a45b)

# Conflicts:
#	.github/workflows/humble-debian-build.yml
#	.github/workflows/humble-rhel-binary-build.yml
#	.github/workflows/iron-debian-build.yml
#	.github/workflows/iron-rhel-binary-build.yml
#	.github/workflows/rolling-debian-build.yml
#	.github/workflows/rolling-rhel-binary-build.yml
@mergify mergify bot mentioned this pull request Feb 7, 2024
Closed
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
@christophfroehlich @mergify
Use correct ref for scheduled workflows (#1013)
595aad2 
(cherry picked from commit 737a45b)

# Conflicts:
#	.github/workflows/humble-debian-build.yml
#	.github/workflows/humble-rhel-binary-build.yml
#	.github/workflows/iron-debian-build.yml
#	.github/workflows/iron-rhel-binary-build.yml
#	.github/workflows/rolling-debian-build.yml
#	.github/workflows/rolling-rhel-binary-build.yml
@mergify mergify bot mentioned this pull request Feb 7, 2024
Closed
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
@bijoua29
Remove log-level argument from spawner script (ros-controls#1013)
e3f38cc 
Use standard ros-args instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@duringhof duringhof Awaiting requested review from duringhof

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @bmagyar