Use non-blocking get_params function on update

ros-controls · Jul 10, 2024 · 4e84b06 · 4e84b06
1 parent 18ce11a
commit 4e84b06
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/joint_trajectory_controller/src/joint_trajectory_controller.cpp b/joint_trajectory_controller/src/joint_trajectory_controller.cpp
@@ -128,9 +128,8 @@ controller_interface::return_type JointTrajectoryController::update(
   }
   auto logger = this->get_node()->get_logger();
   // update dynamic parameters
-  if (param_listener_->is_old(params_))
+  if (param_listener_->try_get_params(params_))
   {
-    params_ = param_listener_->get_params();
     default_tolerances_ = get_segment_tolerances(logger, params_);
     // update the PID gains
     // variable use_closed_loop_pid_adapter_ is updated in on_configure only

diff --git a/pid_controller/src/pid_controller.cpp b/pid_controller/src/pid_controller.cpp
@@ -419,7 +419,7 @@ controller_interface::return_type PidController::update_and_write_commands(
   const rclcpp::Time & time, const rclcpp::Duration & period)
 {
   // check for any parameter updates
-  update_parameters();
+  param_listener_->try_get_params(params_);
 
   if (params_.use_external_measured_states)
   {