-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changes to support robot description #83
API changes to support robot description #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
The rest looks great :)
Thanks for the nice work
kinematics_interface/include/kinematics_interface/kinematics_interface.hpp
Outdated
Show resolved
Hide resolved
kinematics_interface_kdl/include/kinematics_interface_kdl/kinematics_interface_kdl.hpp
Outdated
Show resolved
Hide resolved
…matics_interface_kdl.hpp
Co-authored-by: Sai Kishor Kothakota <[email protected]>
kinematics_interface/include/kinematics_interface/kinematics_interface.hpp
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 79.44% 80.20% +0.75%
==========================================
Files 4 4
Lines 180 197 +17
Branches 18 35 +17
==========================================
+ Hits 143 158 +15
- Misses 27 28 +1
- Partials 10 11 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed in #66. This replaces it.
The Admittance Controller changes are in ros-controls/ros2_controllers#