feat(session): used django session to store AWS credentials #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronilrufo-domain
added
bug
ronilrufo-domain
force-pushed
the
feature/rr/use-django-session-for-aws-credentials
branch
from
ae64df8
to
055c701
Compare
kayne-dmn
reviewed
Jul 4, 2024
kayne-dmn
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
File upload using django-s3direct breaks when you are in a load-balanced environment. This is what we've seen in our investigation and is the same issue that was reported here and here (EvaporateJS).
How
This solution makes use of Django's session framework to temporarily store the AWS credentials so it will persist across different EC2 instances in a load-balanced environment.
This works in our case because we use short-lived AWS credentials. The credentials that our instances use expires after an hour.