Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add COMMIT_SHA to Docker build action #348

Closed
wants to merge 6 commits into from
Closed

chore: add COMMIT_SHA to Docker build action #348

wants to merge 6 commits into from

Conversation

malta895
Copy link
Contributor

@malta895 malta895 commented May 28, 2024 •
edited
Loading

Fixes #347

@malta895 malta895 marked this pull request as draft May 28, 2024 14:33
malta895
malta895 commented May 28, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@malta895 malta895 marked this pull request as ready for review May 28, 2024 14:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9271312953

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.91%
Totals Coverage Status
Change from base Build 9030970221: 0.0%
Covered Lines: 2324
Relevant Lines: 2737
💛 - Coveralls

malta895
malta895 commented May 28, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
malta895
malta895 commented May 28, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@malta895 malta895 marked this pull request as draft May 28, 2024 16:04
@fredmaggiowski
Copy link
Member

fredmaggiowski commented Oct 18, 2024 •
edited
Loading

COMMIT_SHA is no longer used in after #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built Docker image is always using vcs.sha label with an unspecified value
3 participants
@malta895 @coveralls @fredmaggiowski