Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable proxy_arp per interface #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kvaps
Copy link

@kvaps kvaps commented Apr 12, 2018

Hi, enabling proxy_arp for all interfaces isn't good idea, because in some configurations it can make loops in local network.
My patch fixes this problem, since enables proxy_arp option only for romana interfaces during the creation.

@kvaps
Copy link
Author

kvaps commented Apr 12, 2018

Seems it also fixes romana/romana#182

@flashvoid
Copy link
Contributor

Hello @kvaps, logging is not enough here since if CNI fails to enable proxy_arp then pod will be unreachable.

Otherwise, it's fine, I will merge it but first please talk to @cgilmour about CLA.

@kvaps
Copy link
Author

kvaps commented Apr 17, 2018

Hi, @flashvoid all changes have been done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants