Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data for Belarus updated #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

f1mishutka
Copy link

Updated and added some data about Belarus.

I don't know what JSON minifier do you use. So I just used terser to minify JSON.
You can run your own after merging this to have CountryData_minify.json file in the same format as before.

@rolinger
Copy link
Owner

mitoteam? Heh, I was just trying to use your MtJpGraph via composer to get it to work with Phpspreadsheet because the native JpGraph does not have a composer install. I had to edit a lot of stuff but ultimately couldn't get it work, now just manual install outlined in jpgraph.net

I will review changes and merge soon.

@f1mishutka
Copy link
Author

Yes, I looked through your repos and found that this one could be useful for one of our projects.

P.S.: We wrote replies to your issue about JpGraph. Having strong intention to solve your problem with it.

@rolinger
Copy link
Owner

All looks good but I will need to go back and find the original minifier I used before I merge this request to ensure everything is still in the same format. I will post the minifier I used too.

@rolinger
Copy link
Owner

My original code that merged quite a few files was all written in PHP.

$fp = fopen($baseDir.'CountryData_minify.json', 'w') ;
fwrite($fp,json_encode($objOut)) ;
fclose($fp) ;

$fp = fopen($baseDir.'CountryData_pretty.json', 'w') ;
fwrite($fp,json_encode($objOut,JSON_PRETTY_PRINT)) ;

With new merge requests going to need a different process to validate the new data matches the original output. Since the existing output is already the merged content I can't run it through my PHP script without writing a new one, and besides, that is not optimal for github repos. This is the first merge request so hadn't had to deal with it before.

@f1mishutka
Copy link
Author

Let me remove CountryData_minify.json from this PR and you will merge full json only and minify it yourself after.

@f1mishutka
Copy link
Author

Done. Now only 'pretty' file is updated by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants