Skip to content

Commit

Permalink
spark: comment notebooks substitution code opencb#13
Browse files Browse the repository at this point in the history 
There is some issue trying to connect "oskar-spark" notebooks with BUILD configuration,
and if you want to work with the BUILD notebooks the changes will be deleted whenever you
mvn install because it restores BUILD folder with his notebooks. So I made some POM CODE
in case you wantt to work there. In this situation, BUILD notebooks will be copied into
oskar-spark before it gets restored.
  • Loading branch information
@roldanx
roldanx committed Jan 9, 2019
1 parent 2f6f92d commit 42936c4
Showing 1 changed file with 19 additions and 18 deletions.
37 changes: 19 additions & 18 deletions oskar-app/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,24 +88,24 @@
<configuration>
<target>

<echo>Removing notebooks from ${build.dir}/../oskar-spark</echo>
<exec executable="rm">
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/variant_filtering.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/variant_filtering_advanced.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/stats.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/facets.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/GWAS.ipynb"/>
</exec>
<!--<echo>Removing notebooks from ${build.dir}/../oskar-spark</echo>-->
<!--<exec executable="rm">-->
<!--<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/variant_filtering.ipynb"/>-->
<!--<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/variant_filtering_advanced.ipynb"/>-->
<!--<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/stats.ipynb"/>-->
<!--<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/facets.ipynb"/>-->
<!--<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/GWAS.ipynb"/>-->
<!--</exec>-->

<echo>Copying notebooks to ${build.dir}/../oskar-spark</echo>
<exec executable="cp">
<arg value="${build.dir}/pyoskar/variant_filtering.ipynb"/>
<arg value="${build.dir}/pyoskar/variant_filtering_advanced.ipynb"/>
<arg value="${build.dir}/pyoskar/stats.ipynb"/>
<arg value="${build.dir}/pyoskar/facets.ipynb"/>
<arg value="${build.dir}/pyoskar/GWAS.ipynb"/>
<arg value="${build.dir}/../oskar-spark/src/main/python/notebooks"/>
</exec>
<!--<echo>Copying notebooks to ${build.dir}/../oskar-spark</echo>-->
<!--<exec executable="cp">-->
<!--<arg value="${build.dir}/pyoskar/variant_filtering.ipynb"/>-->
<!--<arg value="${build.dir}/pyoskar/variant_filtering_advanced.ipynb"/>-->
<!--<arg value="${build.dir}/pyoskar/stats.ipynb"/>-->
<!--<arg value="${build.dir}/pyoskar/facets.ipynb"/>-->
<!--<arg value="${build.dir}/pyoskar/GWAS.ipynb"/>-->
<!--<arg value="${build.dir}/../oskar-spark/src/main/python/notebooks"/>-->
<!--</exec>-->

<echo>Preparing ${build.dir} folder</echo>
<exec executable="rm">
Expand Down Expand Up @@ -141,13 +141,14 @@
<echo>Copying pyoskar to ${build.dir}</echo>
<exec executable="cp">
<arg value="-r"/>
<!--WHY IS IT NECESSARY EVERYTHING INSIDE PYOSKAR??-->
<arg value="${project.basedir}/../oskar-spark/src/main/python/pyoskar"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/variant_filtering.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/variant_filtering_advanced.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/stats.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/facets.ipynb"/>
<arg value="${project.basedir}/../oskar-spark/src/main/python/notebooks/GWAS.ipynb"/>
<arg value="${project.basedir}/../oskar-app/app/pyoskar/pyoskar-nb.sh"/>
<arg value="${project.basedir}/app/pyoskar/pyoskar-nb.sh"/>
<arg value="${build.dir}/pyoskar"/>
</exec>

Expand Down

0 comments on commit 42936c4

Please sign in to comment.