Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved version of Detail View #143

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Improved version of Detail View #143

merged 2 commits into from
Jun 17, 2019

Conversation

ferion11
Copy link

For the #135
I'm using this on my notebook.

@rodlie
Copy link
Owner

rodlie commented Jun 13, 2019

Thanks, I will review the changes tomorrow.

@rodlie
Copy link
Owner

rodlie commented Jun 17, 2019

Sorry for the late reply. Looks ok, but files should not have the expand icon.
qtfm-detailview-bug

@ferion11
Copy link
Author

On the View the files don't have expand icon. If you use the "QFileSystemModel", the expand icon show only for directory. But the "myModel" (from libfm) is saying that the file item can be expanded. I thought it was a feature, such as for previewing files or opening compressed files as if they were directories. I will review the "myModel" (from libfm) code.

@rodlie
Copy link
Owner

rodlie commented Jun 17, 2019

ahh, yes. Then we have a bug in mymodel.

@rodlie rodlie merged commit 3d787ff into rodlie:master Jun 17, 2019
@rodlie
Copy link
Owner

rodlie commented Jun 18, 2019

fixed in master.

@rodlie
Copy link
Owner

rodlie commented Jun 18, 2019

But that broke the tree dock... Will look into that later.

@ferion11
Copy link
Author

Probably because directories aren't the only ones having children. Some like this should solve:
if (!parent.isValid()) return true; // for drives

@rodlie
Copy link
Owner

rodlie commented Jun 18, 2019

Seems to work, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants