Prevent crash when the document kind is unknown (#11)

indexmanager/index_repository.go

@@ -108,7 +108,7 @@ func (ir *indexRepository) CreateIndex(ctx context.Context, indexName, aliasName
 		return fmt.Errorf("unexpected status code after creating index: %d", res.StatusCode)
 	}
 
-	log.Info("index created", zap.String("index", indexName))
+	log.Info("index created")
 
 	return nil
 }

indexmanager/migration.go

@@ -60,6 +60,7 @@ func NewMigrator(
 }
 
 func (m *migrator) GetMigrations(ctx context.Context) ([]*Migration, error) {
+	log := m.logger.Named("GetMigrations")
 	res, err := m.client.Indices.Get([]string{ElasticsearchAllIndices}, m.client.Indices.Get.WithContext(ctx))
 	if err := getErrorFromESResponse(res, err); err != nil {
 		return nil, err
@@ -79,6 +80,11 @@ func (m *migrator) GetMigrations(ctx context.Context) ([]*Migration, error) {
 		}
 
 		indexParts := m.registry.ParseIndexName(indexName)
+		if indexParts == nil {
+			log.Warn("Discovered index matching criteria, but wasn't able to determine document kind.", zap.String("index", indexName))
+			continue
+		}
+
 		currentVersion := m.registry.Version(indexParts.DocumentKind)
 
 		if indexParts.Version == currentVersion {

indexmanager/migration_test.go

@@ -228,6 +228,17 @@ var _ = Describe("Migrator", func() {
 			})
 		})
 
+		When("an index matches the criteria but isn't in the registry", func() {
+			BeforeEach(func() {
+				mockRegistry.ParseIndexNameReturns(nil)
+			})
+
+			It("should not return an error", func() {
+				Expect(actualMigrations).To(BeEmpty())
+				Expect(actualError).NotTo(HaveOccurred())
+			})
+		})
+
 		When("an error occurs fetching indices", func() {
 			BeforeEach(func() {
 				mockTransport.preparedHttpResponses[0] = &http.Response{

indexmanager/registry.go

@@ -35,6 +35,7 @@ type MappingsRegistry interface {
 	// Mapping returns the current versioned mapping for the document kind.
 	Mapping(documentKind string) *VersionedMapping
 	// ParseIndexName determines the version, document kind, and inner name of an index.
+	// If the document kind cannot be determined, nil is returned
 	ParseIndexName(indexName string) *IndexName
 }
 

indexmanager/registry_test.go

@@ -346,6 +346,16 @@ var _ = Describe("MappingsRegistry", func() {
 				Expect(actualIndexName.Inner).To(Equal("long-inner-name"))
 			})
 		})
+
+		When("the document kind is unknown", func() {
+			BeforeEach(func() {
+				indexName = "rode-v1alpha1-foo"
+			})
+
+			It("should indicate that the document kind isn't in the registry", func() {
+				Expect(actualIndexName).To(BeNil())
+			})
+		})
 	})
 })