updated unifi-linuxserver

[magicalyak]

Updated repo to point to new linuxserver unfi-controller repo since the unifi repo is depracted. The version is already out of support. The new repo is under support and has no impact on an existing installation. It is also recommended by unifi as the preferred docker method. We also have an option for an extra argument to cap memory but I put that in the more_info section rather than forcing the user to enter it. This is for #191

[phillxnet]

@magicalyak Appologies for slow response. Another fine contribution here, thanks. I'd love to merge this but given I know nothing about it I'd rather have another set of eyes on it quickly before we merge and publish.

Adding a needs review and if all looks good we can get this out.

Thanks again @magicalyak I'm sure this will be much appreciated.

But given you are one of our main rock-on reviewers and this is a fairly trivial change buzz here again if we get no review takers and we can take it from there.

A quick note however: we are trying to surface both the upstream project, via the website entry (Rock-on title) and the docker image used. The latter we are some what awkwardly embedding in the description currently. So this pr might be a good time to give this rock-on that particular face lift. Then we honour the upstream project and surface the particular docker image at the same time.

The few examples we currently have of this direction are the following:

Pi-Hole which you and @FroggyFlox recently worked on.
and
Seafile
and
Teamspeak
So if you fancy upping this one to match them that would be great. Just trying to nudge all new Rock-ons commits to conform to this pattern. We need a nicer internal system really but at least this way we present better and honour the upstream projects with the main link as the docker links are often more of lower level technical interest.

Hope your game and thanks again for getting this older image problem sorted.

[phillxnet]

@magicalyak Linking for context to our related issue re sorting a 'proper' system to surface both the upstream project and the docker image used:

Make Rock-on links consistent #31

[magicalyak]

Does that work? @phillxnet

[FroggyFlox]

Thanks a lot for catching this @magicalyak !
I can confirm it works as intended: installs, toggles ON/OFF, and uninstalls without error. The webUI is also accessible without problem.

I took the liberty to suggest the changes @phillxnet referred to.

Thanks again!

[mikey0000]

I'm guessing this will default to the latest tag, from what I can see it is correct (from my review) for what thats worth.

[phillxnet]

@mikey0000 A belated thanks for your input and yes all Rock-ons, if no tag is specified, will default to the latest.
@magicalyak Do you fancy committing @FroggyFlox suggestions and then we can get this one sorted at last.
Cheers.

[magicalyak]

Yes will do @phillxnet

[magicalyak]

@phillxnet @FroggyFlox suggestions committed, apologies for delay.

[phillxnet]

@magicalyak and @FroggyFlox Thanks for getting this much needed update into shape.
Merging now and publishing soon their after.

Fixes #191

[phillxnet]

@mikey0000 Thanks again for taking a look at this proposed Rock-on. Should be out shortly.

[phillxnet]

@magicalyak @FroggyFlox @mikey0000 This Rock-on update is now live.
Thanks.