Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds yaw offset property #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rauldg
Copy link

@Rauldg Rauldg commented Jan 26, 2024

since the init pose property ignores the orientation part of the pose

@chhtz
Copy link
Member

chhtz commented Feb 2, 2024

I would kind-of prefer fixing the start_pose functionality. E.g., just always output start_pose * odo_pose (where odo_pose is what is currently calculated when start_pose is not set). But then renaming start_pose to pose_offset would probably make more sense. And it would be something which would also be achievable with the transformer (probably not as convenient as with a property).

I'll ask some other SLAM users for their opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants