Sklearn compatibility #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
===========================================
- Coverage 94.08% 82.63% -11.46%
===========================================
Files 8 8
Lines 1217 1215 -2
Branches 313 306 -7
===========================================
- Hits 1145 1004 -141
- Misses 36 173 +137
- Partials 36 38 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Thank you very much for the pull request, it's a great change. We won't currently integrate it directly but will point other users to this pull request if they need it, with new versions of sklearn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added decorator to adjust the arguments to the sklearn's NMF constructor such that the >=1.0 implementation's objective is identical to <= 1.0 implementation. Specifically, it generates alpha_W & alpha_H from the passed alpha parameter such that the alpha's in the objective match after scaling (there is not option to turn off scaling the alpha's in the new implementation). Results match original implementation with 1e-7 tolerance. Not sure if fix is compatible with python 2.
Added option for MiniBatchNMF with decorator so that it is also compatible.