Enable Windows in CI #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix Windows compilation on ROS Humble, this PR:
#define _USE_MATH_DEFINESto permit to useM_PI,BUILD_SHARED_LIBSset toONby default. This is not strictly necessary, but it is done to workaround a bug inrosidl_typesupport_fastrtps_cppandrosidl_typesupport_fastrtps_con ROS Humble when whenBUILD_SHARED_LIBSis set toOFF, see error C2491 "definition of dllimport function not allowed" on downstream package on Windows when compiled with BUILD_SHARED_LIBS set to OFF RoboStack/ros-humble#1 .