Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration files for an experimental setup #701

Merged
merged 6 commits into from
Dec 31, 2024

Conversation

AntonioViscomi
Copy link

Added configuration files for our experimental Camozzi linear actuator setup.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AntonioViscomi ,

Could you push to your branch https://github.com/AntonioViscomi/robots-configuration/tree/ankle-setup a README.md file under the path ankleSetup providing a brief description of the context?

Once done, I'll be happy to merge the PR.

@pattacini pattacini requested a review from valegagge December 30, 2024 11:34
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AntonioViscomi , all is fine.I asked two minor changes only.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice the idea of including an image 💯
However, 1.31 MB is a bit too much for the purpose.
Could you make it smaller than 100 KB?

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also changed the extension of the image file, hence the README needs to be updated accordingly.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AntonioViscomi for the mods!
I've pointed out a few amendments as suggestions that I'll commit straight away.

experimentalSetups/ankleSetup/README.md Outdated Show resolved Hide resolved
experimentalSetups/ankleSetup/README.md Outdated Show resolved Hide resolved
@pattacini
Copy link
Member

Awaiting @valegagge final approval before merging.

@AntonioViscomi
Copy link
Author

Thank you @pattacini for your revision!

@pattacini
Copy link
Member

I've seen that you addressed @valegagge's concerns so I think we can make it within 2024!
Feel free to drop further comments.

@pattacini pattacini merged commit 754608b into robotology:devel Dec 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants