-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration files for an experimental setup #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonioViscomi ,
Could you push to your branch https://github.com/AntonioViscomi/robots-configuration/tree/ankle-setup a README.md
file under the path ankleSetup
providing a brief description of the context?
Once done, I'll be happy to merge the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AntonioViscomi , all is fine.I asked two minor changes only.
experimentalSetups/ankleSetup/ankleSetup_telemetry_data/bufferConfigankleSetup_test.json
Outdated
Show resolved
Hide resolved
7af07d3
to
2842e72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice the idea of including an image 💯
However, 1.31 MB is a bit too much for the purpose.
Could you make it smaller than 100 KB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also changed the extension of the image file, hence the README needs to be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README formatting needs improvements.
Take a look at https://github.com/AntonioViscomi/robots-configuration/tree/ankle-setup/experimentalSetups/ankleSetup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AntonioViscomi for the mods!
I've pointed out a few amendments as suggestions that I'll commit straight away.
Awaiting @valegagge final approval before merging. |
Thank you @pattacini for your revision! |
I've seen that you addressed @valegagge's concerns so I think we can make it within 2024! |
Added configuration files for our experimental Camozzi linear actuator setup.