Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup additional Linux dependencies on conda and fix CI #1224

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Dec 23, 2024

More and less ~1 week ago the conda CI job started failing with error:

2024-12-23T13:18:19.1027269Z FAILED: src/visualization/CMakeFiles/idyntree-visualization.dir/src/Visualizer.cpp.o 
2024-12-23T13:18:19.1035277Z /home/runner/micromamba/envs/idyntreedev/bin/x86_64-conda-linux-gnu-c++ -DIDYNTREE_USES_ASSIMP -DIDYNTREE_USES_IRRLICHT -Didyntree_visualization_EXPORTS -I/home/runner/work/idyntree/idyntree/src/visualization/include -I/home/runner/work/idyntree/idyntree/src/core/include -I/home/runner/work/idyntree/idyntree/build/src/core -I/home/runner/work/idyntree/idyntree/src/model/include -I/home/runner/work/idyntree/idyntree/build/src/model -isystem /home/runner/micromamba/envs/idyntreedev/include/eigen3 -isystem /home/runner/micromamba/envs/idyntreedev/include/irrlicht -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/runner/micromamba/envs/idyntreedev/include -O3 -DNDEBUG -fPIC -Wall -Wextra -Woverloaded-virtual -pedantic -MD -MT src/visualization/CMakeFiles/idyntree-visualization.dir/src/Visualizer.cpp.o -MF src/visualization/CMakeFiles/idyntree-visualization.dir/src/Visualizer.cpp.o.d -o src/visualization/CMakeFiles/idyntree-visualization.dir/src/Visualizer.cpp.o -c /home/runner/work/idyntree/idyntree/src/visualization/src/Visualizer.cpp
2024-12-23T13:18:19.1043701Z In file included from /home/runner/micromamba/envs/idyntreedev/include/GLFW/glfw3native.h:118,
2024-12-23T13:18:19.1044811Z                  from /home/runner/work/idyntree/idyntree/src/visualization/src/Visualizer.cpp:33:
2024-12-23T13:18:19.1046506Z /home/runner/micromamba/envs/idyntreedev/include/X11/Xlib.h:44:10: fatal error: X11/X.h: No such file or directory
2024-12-23T13:18:19.1047459Z    44 | #include <X11/X.h>

I am not sure what changed, but anyhow switching to xorg-xorgproto and libgl-devel is the right thing to do, see conda-forge/conda-forge-pinning-feedstock#6688 and conda-forge/conda-forge-pinning-feedstock#6816 .

@traversaro
Copy link
Member Author

Note that the proper solution is to add a glfw3-devel package that depends on all the required packages (see RoboStack/robostack.github.io#65) but as a fast solution manually adding the transitive *-devel dependency is perfectly fine.

Copy link
Contributor

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traversaro, LGTM

@traversaro traversaro merged commit 5ea59c9 into master Dec 23, 2024
19 checks passed
@traversaro traversaro deleted the traversaro-patch-8 branch December 23, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants