Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont ping the hub while posting network information #274

Open
piyushk opened this issue May 13, 2014 · 1 comment
Open

Dont ping the hub while posting network information #274

piyushk opened this issue May 13, 2014 · 1 comment
Labels

Comments

@piyushk
Copy link
Collaborator

piyushk commented May 13, 2014

https://github.com/robotics-in-concert/rocon_multimaster/blob/hydro-devel/rocon_gateway/src/rocon_gateway/gateway_hub.py#L193

Pinging the hub has nothing to do with the local network information being available. This should be broken out in its own separate function and called after publish_network_statistics. In situations where the local network information is not available, but the connection to the hub is alive, this will cause an error

@piyushk piyushk added the bug label May 13, 2014
@stonier
Copy link
Member

stonier commented May 14, 2014

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants