Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test case status and log status to be different #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joaonc
Copy link

@joaonc joaonc commented Nov 28, 2018

Small fix to allow different expected statuses for the test case outcome and individual LOG messages, which can be different when:

  • Running keywords such as Run Keyword And Expect Error.
    Test case may PASS while the log level is FAIL.
  • Checking the log for a passing step on a failing test case.
    Test case is FAIL, but the log level is INFO (or some other level).

Fixes issue #4

@joaonc
Copy link
Author

joaonc commented Nov 28, 2018

Note: At this point, this fix is not 100% functional.
The existing test cases pass (there seem to be no breaking changes), but the new functionality is either not working or the test cases are not working (due to the Status keyword in all tests).

The (new) test cases below should be working but are failing:

  • Test case PASS log INFO
  • Test case FAIL log FAIL
  • Test case PASS log FAIL
  • Test case FAIL log INFO

@pekkaklarck Can you take a look?

@pekkaklarck
Copy link
Member

On a quick look it seems to me you haven't specified expected messages in the documentation for the failing tests.

@joaonc
Copy link
Author

joaonc commented Nov 28, 2018

Duh.. you were right. Fixed test cases and things should be good now.
SeleniumLibrary PR #1244 depends on this fix for Travis CI to pass.

Note: Wasn't sure whether or not to mark version as 1.4. Not sure why it was devel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants