Python 3 12 #1916
Merged
Python 3 12 #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Should Detect Page Loads While Waiting On An Async Script And Return An Error" is showing some differences I believe with the current Chrome browser version 128. Going to temporarily triage it and see if there are other issues within the test matrix.
Removed 5.0.1 as it is not compatable with Python3.12 (which came in RF version 6.1). Also bumped 7.0 to 7.0.1.
- also cleaned up the github runner
As I did not keep up with the selenium version over the summer going to test from 4.21.0 to latest (4.24.0)
As we now are only testing Selenium version 2.21 or greater I removed the check to see the correct method name for getting the binaries with Selenium Manage.
aaltat
approved these changes
Sep 6, 2024
| @@ -114,6 +116,19 @@ def test_parse_options_string_errors(options, reporter): | |||
| verify_all("Selenium options string errors", results, reporter=reporter) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds") | |||
There was a problem hiding this comment.
I think Approval tests did fix this problem and skipping in Windows could be removed now days. Doesn’t have to be this PR tough.
yuriverweij
approved these changes
Sep 6, 2024
emanlove
added
enhancement
priority: high
acknowledge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Python 3.12