Open browser options bug #1877 #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the selenium options argument of the `Open Browser` keword, if there were trailing semicolons then the keyword would fail. With this change we allow trailing semicolons. In addition the library warns about emtpy options. Fixes robotframework#1877
|
Kiitos Tatu! |
|
Although failures in utest needs looking. |
|
.. was just checking that out. Didn't fail previously under Windows. Checking Linux (via WSL) |
The new selenium options parser has a slightly different behaviour when it comes to multiple arguments with generious spacing within its option string. In stead of leaving preceeding and trailing spaces it removes those. This change is approved files corrects for this change.
I let this leak in. It shouldn't be there and it looks like it is causing trouble in GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for semicolon at end of selenium options. Also handles issue of empty options if for example an extra semicolon is put into the options. In such cases we ignore the empty option and publish a warning.
Fixes #1877