-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test under selenium versions #1875
Merged
emanlove
merged 13 commits into
robotframework:master
from
emanlove:update-test-under-selenium-versions
Dec 19, 2023
Merged
Update test under selenium versions #1875
emanlove
merged 13 commits into
robotframework:master
from
emanlove:update-test-under-selenium-versions
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also documented some temporary changes to GitHub Actions test execution - Corrected pypy version in conditional check
Removed python version greater than 60 days old
As a way to deal with constantly changing selenium-manager logging which affects our status checking I implemented this change. Works fine with GitHub CI but has some issues on local. In particular under Windows build & test it is problematic under virtualenvs. It is possible to resolve but right now its just too problematic .. so pulling out this change for now.
As written this is an invalid test given current functionality. One can not give a list directly as a locator. (It is possible to check a list of elements by using a cascaded locator in that for the end locator to be found all ther other ones must be there as well. But thi is really a different type of locator as list check). I am not opposed to expanding the functionality to include this but as currently stands I see this as an invilad check on functionality that is not yet provided.
- Updated to latest 6.1.1 version of Robot Framework - Added Selenium v4.16.0 and dropped 4.13.0 from test matrix
The `Test Get Cookie Keyword Logging` test case has a slight issue in that Get Cookie returns the expir date and converts to local timezone. So it makes it difficult to run both within CI and across all our developers timezones without failing. This change is made to correct for that. I do see that we could shift this some more so that UTC expiry keeps within the same day from a California to Australia execution.
- Also renamed the test result archive removing the work "Failed" as they are not always failed.
Switched expected log level from INFO to ANY as for version 7.0b1 has a change that for a change in loglevel downward should affect the logging level of that action. Switched to ANY to allow for both prior verison and future versions to check this.
Triaging the `Test Minimize and Maximize Will Actually Move and Resize Window` test case. There is a known issue with trying to get this to pass and so sort of confirguration needs to be tried out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some improvements to the test matrix adding in various selenium versions. This increase the test matrix which I will narrow down. But merging this in now gives us a chance to test some of the latest versions.