Remote browser without options 1855 #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For several of the remote browsers we need to initialize the options if none are provided. In addition I removed the deprecated and removed from selenium desired_capabilities. This fixes robotframework#1855.
This is an initial attempt/design for a test suite that verifies "remote" browsers work without options. This is to test against the issue outlined in robotframework#1855. I have been manually runnning the webdrivers locally but this second edition is trying to do that in the setup and then cleanup in the teardown. For some reason this is not working and I need to investigate further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For several of the remote browsers we need to initialize the options if none are provided. In addition I removed the deprecated and removed from selenium desired_capabilities. Although a work in progress I want to get in the initial fix so we can create a release candidate and see how it works in the field.