Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes to improve compatiblity with python3 #133

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dilawar
Copy link

@dilawar dilawar commented Mar 21, 2018

  • removed some python3 incompatible statements.
  • Fixed some test scripts.
  • python3 does not accept float as index. Converted indices to int in many places.
  • Minor tweaks to some functions for passing plotting arguments such as color, alpha etc esp. in phaseplane.
  • scipy 1.x compatible (this is from @tkf ).

@Silmathoron
Copy link

Silmathoron commented Jan 28, 2019

Hi there, this PR seems very useful (I just had to hack the whole scipy part myself).
Is there something specific preventing it from being merged? (except for the necessary pull from master?)
Is it possible to help with this in any way?

@z2v
Copy link
Collaborator

z2v commented Jan 29, 2019

@Silmathoron Most changes have been already merged to master. I'll take a look and cherry-pick whether there are more changes.

@Silmathoron
Copy link

Ok, that's good to hear! I was using the PyPi version so I'll probably just switch to master, thank you

@robclewley robclewley mentioned this pull request Jan 2, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 11.311% when pulling f48b6ef on dilawar:master into 45fc2f1 on robclewley:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants