Add .netrc support #82
Conversation
| if err != nil { | ||
| return nil, fmt.Errorf("getting current user: %w", err) | ||
| } | ||
| n, err := netrc.Parse(filepath.Join(usr.HomeDir, ".netrc")) |
There was a problem hiding this comment.
bazaldnf is consumed internally by the bazel rules. It seems like this would break hermeticity in that case?
There was a problem hiding this comment.
AFAICT this part of bazeldnf runs in the repository rule / loading phase, which is "allowed" to poke at local files and perform network calls.
Also, this is reading the .netrc file to supply credentials to a http GET request. The GET request itself is also not hermetic.
There was a problem hiding this comment.
Moreso what I was getting at is that this dependency is opaque to everything that consumes bazeldnf itself. ie: how would you identify this as something that you build depends on?
There was a problem hiding this comment.
Bazel already defaults to reading ~/.netrc for the built in http_archive rules (see https://github.com/bazelbuild/bazel/blob/master/tools/build_defs/repo/http.bzl#L144 and https://github.com/bazelbuild/bazel/blob/master/tools/build_defs/repo/utils.bzl#L460 which show how it's implemented) without any additional configuration from the user. This is well established behaviour.
Actually, I had another look through the code and I'll go back on my previous statement. I don't think this code path runs as part of the build at all:
- the
bazeldnftarget is only exposed as a user convenience, so you canbazel runit, and so we should not consider the entirebazeldnfcommand with all of its subcommands to be part of the build (though, yea, sure, someone could run it as part of their custom rule or a genrule, but that's on them), - the two rules that invoke
bazeldnfarerpm2tarandtar2files, neither of which use therepopackage, so they shouldn't hit this code path, - the
rpmrules use Bazel's downloader to download the files.
In other words these changes only affect bazeldnf invocations that are performed by the user locally prior to the build (like bazeldnf rpmtree) and so build hermeticity concerns shouldn't come into play at all.
This is to support something like an internal mirror (such as Artifactory).
It's possible to use an one by hand-crafting a
repo.yamlfile, but things get tricky if such a mirror requires authentication.This adds support for basic auth driven by a .netrc file.