Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve setup #76

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci: improve setup #76

merged 1 commit into from
Jul 17, 2024

Conversation

manuelnaranjo
Copy link
Contributor

Using a matrix instead of copying the test structure so many times

@manuelnaranjo manuelnaranjo force-pushed the mnaranjo/ci-workspace branch from 9026b84 to 19d57b9 Compare July 16, 2024 09:41
@manuelnaranjo
Copy link
Contributor Author

@rmohr this is ready to be reviewed and merged, it reduces how many files I touch on my other PR

@manuelnaranjo manuelnaranjo force-pushed the mnaranjo/ci-workspace branch 2 times, most recently from 3a80443 to bbc16d9 Compare July 16, 2024 14:16
@manuelnaranjo manuelnaranjo force-pushed the mnaranjo/ci-workspace branch from bbc16d9 to a87dc08 Compare July 16, 2024 14:39
Makefile Outdated Show resolved Hide resolved
.github/workflows/action.yml Outdated Show resolved Hide resolved
@manuelnaranjo manuelnaranjo force-pushed the mnaranjo/ci-workspace branch from a87dc08 to 021fc06 Compare July 17, 2024 06:38
Using a matrix instead of copying the test structure so many times, make
CI explicit about us using bazelisk and not plain bazel
@manuelnaranjo manuelnaranjo force-pushed the mnaranjo/ci-workspace branch from 021fc06 to fc01ee5 Compare July 17, 2024 06:42
@manuelnaranjo
Copy link
Contributor Author

@rmohr alright is updated now and uses bazelisk explicitly both in Makefile and CI

@rmohr rmohr merged commit af66929 into rmohr:main Jul 17, 2024
4 checks passed
@manuelnaranjo manuelnaranjo deleted the mnaranjo/ci-workspace branch July 17, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants