Fix resource pool creation with '/' in name fog#261

This fixes naming of resource pools which contains '/' symbol. Bug is coused by rbvmomi transpolation '/' to '%2f' and while creating nested resource pool we can't find it in parent resource pool which contains '/'.
rlazoryshchak · Aug 20, 2020 · 5f76380 · 5f76380
1 parent 1ee4ecf
commit 5f76380
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/fog/vsphere/requests/compute/create_resource_pool.rb b/lib/fog/vsphere/requests/compute/create_resource_pool.rb
@@ -6,17 +6,19 @@ def create_resource_pool(attributes = {})
           cluster = get_raw_cluster(attributes[:cluster], attributes[:datacenter])
 
           root_resource_pool = if attributes[:root_resource_pool_name]
-                                 cluster.resourcePool.find attributes[:root_resource_pool_name]
+                                 cluster.resourcePool.find attributes[:root_resource_pool_name].gsub('/', '%2f')
                                else
                                  cluster.resourcePool
                                end
 
-          root_resource_pool.CreateResourcePool(
+          raise ArgumentError, 'Root resource pool could not be found' if root_resource_pool.nil?
+
+          resource_pool = root_resource_pool.CreateResourcePool(
             name: attributes[:name],
             spec: get_resource_pool_spec(attributes)
           )
 
-          get_resource_pool(attributes[:name], attributes[:cluster], attributes[:datacenter])
+          resource_pool_attributes(resource_pool, attributes[:cluster], attributes[:datacenter])
         end
 
         private

diff --git a/lib/fog/vsphere/requests/compute/update_resource_pool.rb b/lib/fog/vsphere/requests/compute/update_resource_pool.rb
@@ -10,7 +10,7 @@ def update_resource_pool(attributes = {})
             config: get_resource_pool_spec(attributes)
           )
 
-          get_resource_pool(attributes[:name], attributes[:cluster], attributes[:datacenter])
+          resource_pool_attributes(raw_resource_pool, attributes[:cluster], attributes[:datacenter])
         end
 
         private