Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for <optgroup> tag #4374

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nagaozen
Copy link

@nagaozen nagaozen commented Nov 11, 2024

Reasons for making this change

HTML Select Element offers a native way to organize options in option groups. This update extends rjsf SelectWidget to support <optgroup> as well.

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

fixes #1813, #580

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@nagaozen Thanks for the new feature... Can you update the CHANGELOG.md to add a new minor release with notes on this feature. Also please update the tests to validate these changes. Thanks

@nagaozen
Copy link
Author

@nagaozen Thanks for the new feature... Can you update the CHANGELOG.md to add a new minor release with notes on this feature. Also please update the tests to validate these changes. Thanks

Sure, must update the CHANGELOG and place some tests.

@nagaozen
Copy link
Author

Alright, checklist completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify JSON Validation for Optgroup support
2 participants