-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new release procedure for Rizin with manual tagging and release creation. #4337
base: dev
Are you sure you want to change the base?
Conversation
What's the issue with GitHub releases? |
@ret2libc It now assigned twice in a row the tag to the |
36268d4
to
c0f9fe8
Compare
Where exactly? In the CI? Maybe we should use |
Not CI - tag was created on |
Please remove instructions about signing, since we need first to decide on how exactly we do that. GitHub "standard" verification isn't enough, especially since they changed ZIP archives once. This is tracked in #3786 |
Yeah I understand, I'm afraid that it's caused by the wrong commit being referenced in the draft release when we create it in the CI. IIRC I "recently" changed that part of the CI as we had to switch GH action for release, so it might behave slightly different and cause this behaviour. |
Your checklist for this pull request
Detailed description
Github releases doesn't seem to work reliably. So this adds the manual release process.
Still missing:
Test plan
...
Closing issues
...