-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RzTypes to use structs instead of SDB + New Tree-Sitter based C Parser #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddee1d2
to
90c445b
Compare
7c2b7ab
to
919f0c4
Compare
eb978b7
to
796c239
Compare
* Fix afs command not work on retval and args * No need to print log again * Add missing types for macos
…individual v1->v2 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command
infrastructure
merge-when-green
refactor
Refactoring requests
rz-test
RzAnalysis
RzBin
RzCore
RzType
test-required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH ME PLEASE
Your checklist for this pull request
Detailed description
t
(types) commandstk
command because types storage switched to the hashtabletfc
command to show the calling convention of the function or set ittsl
(RZ_OUTPUT_MODE_LONG) to show structure members' sizes and offsetstul
(RZ_OUTPUT_MODE_LONG) to show union members' sizeschar *type
occurences to the properRzType
RzCallable
type for the function/class method typesRzCallable
APIRzCallable
) storage to the hashtable instead of SDBRzAnalysisFunction
andRzCallable
-rz_analysis_function_derive_type()
API function to derive newRzCallable
type from theRzAnalysisFunction
even if it doesn't exist in the RzTypeDB.librz/type/parser/*
)librz/analysis/d/
to be consistent with C standard, libc, platform-specific definitionschar *
toRzType
a.b[20].c
whereb
is a member ofa
(a
is either structure or a union) andc
is a member ofb
, andb
is an array where we take 20-th element.None
(the most generic one),Num
(includesIntegral
andFloating
),Integral
(includesSigned Integral
andUnsigned Integral
),Floating
.rz_types_equal(a, b)
API function)librz/type/*
.Test plan
CI is green
Closing issues
Fixes #371
Fixes #370
Fixes #373
Fixes #275
Fixes #1249
Partially addresses #1169, #1064