-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/projects api #189
base: main
Are you sure you want to change the base?
Dev/projects api #189
Conversation
+ new project seed data + new project api methods + new project api tests * currently cant test some of the tests because of auth; waiting to rebase off that
…nto dev/projects-api
+ fixed tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you manually tested? I'm worried the GET routes wouldn't have the right amount of data returned without explicitly using the select clause.
next/prisma/schema.prisma
Outdated
} | ||
|
||
//Account model represents an account in the system. | ||
//It contains information about the user, the type of account, and the authentication provider. | ||
//It contains information about the user, the type of account, and the authentication `vider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i actually have no idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed i suppose
i did :) |
…jects + new tests for userProject + updated tests to not interfere with userProject tests
Added implementation for contributers on projects. |
Noticed you're using a different indentation than the rest of the project. It should be 2 spaces indentation project-wide. Everyone should be set up with the same prettier formatting settings, but maybe that wasn't set up properly? |
Yeah I noticed that too, lemme look into it. |
There is no prettier config file in the repo at all. Without this prettier uses the user's default settings. If you want the consistency then someone needs to add the config file, otherwise you can expect the styles not to match as it's not documented anywhere (at least I couldn't find it) |
Yeah, I just added one on my end. |
Not your fault! You're absolutely right, there isn't one. This is definitely something we should fix. I created a ticket for this. Feel free to edit it or drop comments as needed (either of you) with your additional thoughts. Conversation is the beating heart of collaboration. |
Thanks! |
it's done !!! check it out