Readme: Fix build instructions #1075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This seems right at first glance. However, it's different than .github/workflows/verify.yml (which I'm not an expert on). Any thoughts on that? And while I'm looking in the .github directory, does .github/workflows/publish.yml need to be updated? It still has the texlive stuff in it.
JanMatCodasip
force-pushed
the
readme-build-instructions
branch
from
4951a5d to
9f5178c
Compare
The Readme contained the old (pre-adoc) build instructions. Fix them to describe the current build process. Mention also the use of submodules, which are needed for the documentation to build.
JanMatCodasip
force-pushed
the
readme-build-instructions
branch
from
9f5178c to
5dc62af
Compare
|
Hello @pdonahue-ventana - I have checked I have also looked at
I propose to remove it (in another merge request: #1078). |
rtwfroody
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Readme still contained old (pre-adoc) build instructions. Fix it.
Mention also the use of submodules which are needed for the documentation to build.