Clarify the restriction on dmcontrol writes while abstractcs.busy is high
#1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtwfroody
reviewed
May 17, 2024
debug_module.adoc
Outdated
Comment on lines
371
to
372
| While an abstract command is executing ({abstractcs-busy} in {dm-abstractcs} is high), a debugger must not change {hartsel}, and must not write 1 to {dmcontrol-haltreq}, {dmcontrol-resumereq}, {dmcontrol-ackhavereset}, {dmcontrol-setresethaltreq}, or {dmcontrol-clrresethaltreq}, | ||
| unless the DM is reset by the same write to {dm-dmcontrol} ({dmcontrol-dmactive} is lowered). |
There was a problem hiding this comment.
This sentence is getting really long.
Suggested change
| While an abstract command is executing ({abstractcs-busy} in {dm-abstractcs} is high), a debugger must not change {hartsel}, and must not write 1 to {dmcontrol-haltreq}, {dmcontrol-resumereq}, {dmcontrol-ackhavereset}, {dmcontrol-setresethaltreq}, or {dmcontrol-clrresethaltreq}, | |
| unless the DM is reset by the same write to {dm-dmcontrol} ({dmcontrol-dmactive} is lowered). | |
| While an abstract command is executing ({abstractcs-busy} in {dm-abstractcs} is high), a debugger must not change {hartsel}, and must not write 1 to {dmcontrol-haltreq}, {dmcontrol-resumereq}, {dmcontrol-ackhavereset}, {dmcontrol-setresethaltreq}, or {dmcontrol-clrresethaltreq}. | |
| The exception to this rule is when 0 is written to {dmcontrol-dmactive}. In that case the DM is reset, and the other values written to {dm-dmcontrol} are ignored. |
… is high With the clarification, it's obvious that the DM can be reset without knowing the `hartsel`. Fixes riscv#1021
en-sc
force-pushed
the
en-sc/dmactive-hartsel
branch
from
6a08d8c to
8f8bd09
Compare
JanMatCodasip
approved these changes
May 27, 2024
|
This is not backwards compatible, and the issue is not severe enough to warrant a backwards-incompatible change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the clarification, it's obvious that the DM can be reset without knowing the
hartsel.Fixes #1021