Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmactive is part of dmcontrol, and debug module version is from dmstatus #1003

Merged
merged 1 commit into from
Apr 24, 2024
Merged

dmactive is part of dmcontrol, and debug module version is from dmstatus #1003

merged 1 commit into from
Apr 24, 2024

Conversation

stefano-codasip
Copy link
Contributor

@stefano-codasip stefano-codasip commented Apr 15, 2024 •
edited
Loading

In section 3.13 (Version Detection) the dmactive bit was wrongly assigned to dmstatus register. Also, the debug module version should be from dmstatus.version rather than tinfo.version

JanMatCodasip
JanMatCodasip approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

pdonahue-ventana
pdonahue-ventana approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These problems were introduced in the Asciidoc conversion process. The .tex files were correct.

@stefano-codasip
Copy link
Contributor Author

@pdonahue-ventana this PR requires a further approval for the Workflow
image

@stefano-codasip
Copy link
Contributor Author

@rtwfroody could you please have a look at this PR, too? thanks :)

@stefano-codasip
Copy link
Contributor Author

@rtwfroody please, let me know if there is any feedback for this PR

rtwfroody
rtwfroody approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@rtwfroody rtwfroody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rtwfroody rtwfroody merged commit e056579 into riscv:main Apr 24, 2024
1 check passed
@rtwfroody rtwfroody added asciidoc asciidoc conversion and removed Bug fix labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMatCodasip JanMatCodasip JanMatCodasip approved these changes

@pdonahue-ventana pdonahue-ventana pdonahue-ventana approved these changes

@rtwfroody rtwfroody rtwfroody approved these changes

Assignees
No one assigned
Labels
1.0 asciidoc asciidoc conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefano-codasip @rtwfroody @pdonahue-ventana @JanMatCodasip