Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .insn directive #109

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

charlie-rivos
Copy link
Contributor

Add .insn directive with brief description and link to full documentation.

Co-developed-by: Tim Hutt [email protected]
Co-developed-by: Christoph Müllner [email protected]

@charlie-rivos
Copy link
Contributor Author

@cmuellner if you think it is valuable I can add all of the instruction formats, or we can leave it as-is and link to the Binutils docs

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good start.
If we decide later to standardize more here, then we can easily extend.
But for now the scope looks reasonable to me.

src/asm-manual.adoc Outdated Show resolved Hide resolved
@cmuellner
Copy link
Collaborator

CC: @asb @kito-cheng @Timmmm

@Timmmm
Copy link
Contributor

Timmmm commented Sep 14, 2024

Did you mean to leave a .patch file in there?

Add .insn directive with brief description and link to full documentation.

Co-developed-by: Tim Hutt <[email protected]>
Co-developed-by: Christoph Müllner <[email protected]>
Signed-off-by: Charlie Jenkins <[email protected]>
@charlie-rivos
Copy link
Contributor Author

Did you mean to leave a .patch file in there?

Whoops, thank you for catching that, I removed it

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well:)

@cmuellner cmuellner merged commit 3b06fa9 into riscv-non-isa:main Sep 18, 2024
@cmuellner cmuellner mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants