-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .insn directive #109
Add .insn directive #109
Conversation
@cmuellner if you think it is valuable I can add all of the instruction formats, or we can leave it as-is and link to the Binutils docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good start.
If we decide later to standardize more here, then we can easily extend.
But for now the scope looks reasonable to me.
CC: @asb @kito-cheng @Timmmm |
a7f6dcc
to
2c666fd
Compare
Did you mean to leave a .patch file in there? |
Add .insn directive with brief description and link to full documentation. Co-developed-by: Tim Hutt <[email protected]> Co-developed-by: Christoph Müllner <[email protected]> Signed-off-by: Charlie Jenkins <[email protected]>
2c666fd
to
b58e604
Compare
Whoops, thank you for catching that, I removed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well:)
Add .insn directive with brief description and link to full documentation.
Co-developed-by: Tim Hutt [email protected]
Co-developed-by: Christoph Müllner [email protected]