target/riscv: new ebreak controls
#1168
Conversation
en-sc
force-pushed
the
en-sc/ebreak
branch
2 times, most recently
from
6b1faa6 to
ccb13a1
Compare
|
@JanMatCodasip, @MarekVCodasip ping |
src/target/riscv/riscv.c
Outdated
| { | ||
| struct riscv_private_config *pc = target->private_config; | ||
| if (!pc) { | ||
| pc = default_riscv_private_config(); |
There was a problem hiding this comment.
There is an issue with private_config deallocation in case of an error.
Please, see https://review.openocd.org/c/openocd/+/8637/comments/512687b3_e6274fb6
There was a problem hiding this comment.
Should be fixed by https://review.openocd.org/c/openocd/+/8642
There was a problem hiding this comment.
The issue is somewhat minor and is not specific to this patch.
IMHO, the patch can be merged without the fix.
There was a problem hiding this comment.
I agree - no problem with merging this now.
* Deprecate `riscv set_ebreak*` commands. * Introduce RISC-V-sepecific `configure` parameter `-ebreak` instead. * Separate controls for VS and VU modes. Change-Id: I0ff88318dcb52af6923eb9f20f9d0c056ad09cf0 Signed-off-by: Evgeniy Naydanov <[email protected]>
|
Please, note: In the last change I didn't only address review comments. |
| if (e != JIM_OK) | ||
| return e; | ||
|
|
||
| if (!goi->isconfigure && goi->argc > 0) { |
There was a problem hiding this comment.
Needs to be adjusted after !1186 is merged due to 8c739a4
riscv set_ebreak*commands.configureparameter-ebreakinstead.Change-Id: I0ff88318dcb52af6923eb9f20f9d0c056ad09cf0